hugopeixoto/yuzu
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

android: jni: native: Remove unnecessary atomic for is_running.

Browse Source
This commit is contained in:
bunnei 2023-01-25 18:42:18 -08:00
parent 9ba67eab4f
commit 104ff475d2
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/android/app/src/main/jni/native.cpp
View File

@ -61,7 +61,7 @@ public:
} }
bool IsRunning() const { bool IsRunning() const {
return is_running.load(std::memory_order_relaxed); return is_running;
} }
const Core::PerfStatsResults& PerfStats() const { const Core::PerfStatsResults& PerfStats() const {
@ -125,14 +125,14 @@ public:
} }
void HaltEmulation() { void HaltEmulation() {
is_running.store(false, std::memory_order_relaxed); is_running = false;
cv.notify_one(); cv.notify_one();
} }
void RunEmulation() { void RunEmulation() {
std::unique_lock lock(mutex); std::unique_lock lock(mutex);
is_running.store(true, std::memory_order_relaxed); is_running = true;
void(system.Run()); void(system.Run());
@ -140,8 +140,7 @@ public:
system.InitializeDebugger(); system.InitializeDebugger();
} }
while (!cv.wait_for(lock, std::chrono::seconds(1), while (!cv.wait_for(lock, std::chrono::seconds(1), [&]() { return !is_running; })) {
[&]() { return !is_running.load(std::memory_order_relaxed); })) {
std::scoped_lock perf_stats_lock(perf_stats_mutex); std::scoped_lock perf_stats_lock(perf_stats_mutex);
perf_stats = system.GetAndResetPerfStats(); perf_stats = system.GetAndResetPerfStats();
} }
@ -162,7 +161,7 @@ private:
std::unique_ptr<EmuWindow_Android> window; std::unique_ptr<EmuWindow_Android> window;
std::mutex mutex; std::mutex mutex;
std::condition_variable_any cv; std::condition_variable_any cv;
std::atomic_bool is_running{}; bool is_running{};
}; };
/*static*/ EmulationSession EmulationSession::s_instance; /*static*/ EmulationSession EmulationSession::s_instance;