1668 Commits

Author	SHA1	Message	Date
Lioncash	9e74d6238e	hid: Stub DisconnectNpad() ... This is required by ARMS.	2018-08-12 05:56:28 -04:00
David Marcec	094f6003e0	Pushed the requested sample rate instead of our fixed sample rate	2018-08-12 14:58:36 +10:00
David Marcec	e5ee0afe6f	Added GetAudioRendererSampleRate, GetAudioRendererSampleCount & GetAudioRendererMixBufferCount ... GetAudioRendererSampleRate is set as a "STUB" as a game could check if the sample rate it sent and the sample rate it wants don't match. Just a thought of something which could happen so keeping it as stub for the mean time	2018-08-12 14:46:12 +10:00
David Marcec	ecfbe7d9c8	Stub UpdateUserPresence ... Needed for Retro City Rampage to go in game	2018-08-12 14:00:44 +10:00
Zach Hilman	c0257cf52f	filesystem: Add Open and Register functions for BISFactory	2018-08-11 22:50:48 -04:00
bunnei	249341d08f	friend: Stub DeclareCloseOnlinePlaySession. ... - Used by Splatoon 2.	2018-08-11 21:34:14 -04:00
bunnei	261a4f0311	friend: Fix CreateFriendService to return an IFriendService interface.	2018-08-11 21:29:58 -04:00
David Marcec	10f494eefe	Better UUID randomness	2018-08-12 02:31:43 +10:00
David Marcec	448290bee4	Removed un-needed count from ListOpenUsers and ListAllUsers	2018-08-12 02:11:04 +10:00
David Marcec	2592e41301	Added better explanations in the profile manager	2018-08-12 01:51:31 +10:00
David Marcec	0b6f8ba51e	Code cleanup for profile manager	2018-08-12 01:34:22 +10:00
David Marcec	d0b2950434	Removed const from ProfileBase Invalidate	2018-08-12 00:41:17 +10:00
David Marcec	42431d2aa6	fixed invalid uuid bool operator	2018-08-11 21:29:10 +10:00
David Marcec	b8e70faa2d	Added GetOpenUserCount	2018-08-11 20:45:06 +10:00
David Marcec	662218e997	Removed all for loops from the profile manager	2018-08-11 20:15:59 +10:00
David Marcec	c3013c7c9c	Added missing ListAllUsers count	2018-08-11 20:06:06 +10:00
David Marcec	acff922762	If statement style change	2018-08-11 18:46:42 +10:00
David Marcec	dfea525cbe	Second round of account changes	2018-08-11 18:26:13 +10:00
David Marcec	82fa0bcea7	First round of account changes	2018-08-11 16:47:33 +10:00
David Marcec	6aa8ee6943	Refactored profile manager sharing	2018-08-11 13:17:06 +10:00
David Marcec	b76ddb7647	Merge remote-tracking branch 'origin/master' into better-account	2018-08-11 10:35:47 +10:00
David Marcec	2a3b335b15	Added IsUserRegistrationRequestPermitted	2018-08-11 10:33:11 +10:00
Lioncash	20c2928c2b	video_core; Get rid of global g_toggle_framelimit_enabled variable ... Instead, we make a struct for renderer settings and allow the renderer to update all of these settings, getting rid of the need for global-scoped variables. This also uncovered a few indirect inclusions for certain headers, which this commit also fixes.	2018-08-10 19:00:09 -04:00
bunnei	5191c20b71	Merge pull request #997 from lioncash/const-func ... core: Make function reference parameters const where applicable	2018-08-09 19:30:51 -04:00
bunnei	69cd213fac	Merge pull request #990 from lioncash/entry ... fsp_srv: Emplace entries first when building index instead of emplacing last	2018-08-09 19:29:36 -04:00
bunnei	96ef22d3d0	Merge pull request #897 from DarkLordZach/vfs-accuracy-2 ... vfs: Add VfsFilesystem and fix RealVfs* implementations	2018-08-09 19:22:06 -04:00
Lioncash	b46a5c42ff	buffer_queue: Make reference parameter of SetPreallocatedBuffer const ... This is simply copied by value, so there's no need to make it a modifiable reference. While we're at it, make the names of the parameters match its definition.	2018-08-09 03:08:14 -04:00
David Marcec	4e1471ef21	Don't add user if the uuid already exists	2018-08-09 13:30:58 +10:00
bunnei	2f4f4f147f	Merge pull request #986 from mailwl/acc-loadimage ... Service/Account: stub LoadImage function	2018-08-08 21:21:06 -04:00
Zach Hilman	4b471f0554	core: Port core to VfsFilesystem for file access	2018-08-08 21:18:45 -04:00
Zach Hilman	b36dee364e	filesystem: Remove unnecessary if conditions	2018-08-08 21:18:45 -04:00
bunnei	9f48454ea9	Merge pull request #978 from bunnei/fixioctl ... nvhost_gpu: Don't over copy IoctlSubmitGpfifo.	2018-08-08 19:16:14 -04:00
Lioncash	7353cfc781	fsp_srv: Use std::string_view's copy() function instead of strncpy() ... Given elements inserted into a vector are zeroed out, we can just copy MAX_LEN - 1 elements and the data will already be properly null terminated.	2018-08-08 18:51:52 -04:00
Lioncash	4afb05d0cc	fsp_srv: Emplace entries first when building index instead of emplacing last ... The current way were doing it would require copying a 768 character buffer (part of the Entry struct) to the new element in the vector. Given it's a plain array, std::move won't eliminate that. Instead, we can emplace an instance directly into the destination buffer and then fill it out, avoiding the need to perform any unnecessary copies. Given this is done in a loop, we can request the destination to allocate all of the necessary memory ahead of time, avoiding the need to potentially keep reallocating over and over on every few insertions into the vector.	2018-08-08 18:51:41 -04:00
bunnei	756e1e6f9b	Merge pull request #975 from bunnei/am-stub ... am: Stub SetScreenShotImageOrientation.	2018-08-08 16:46:45 -04:00
bunnei	448264e719	Merge pull request #958 from lioncash/nv-global ... nvdrv: Get rid of global std::weak_ptr	2018-08-08 11:58:45 -04:00
David Marcec	e9978fd4f5	Open first user added	2018-08-09 01:37:55 +10:00
David Marcec	75169c7570	Inital pass of account backend implementation ... This commit verified working on puyo	2018-08-09 01:09:12 +10:00
David Marcec	03d7faf583	GetProfileBase and GetProfileBaseAndData added	2018-08-08 23:41:12 +10:00
David Marcec	6f691e71bf	began initial implementation of "ProfileManager"	2018-08-08 22:26:42 +10:00
mailwl	c0d44d3b2a	Service/Account: stub LoadImage function	2018-08-08 14:42:54 +03:00
David Marcec	5f8d253ce0	Switched uuids from u128 to new UUID struct	2018-08-08 21:09:45 +10:00
bunnei	4941e3d412	Merge pull request #974 from lioncash/acc ... acc: Add missing function table entries for GetUserCount	2018-08-08 02:56:00 -04:00
mailwl	3c498189b6	hid: fix IsSixAxisSensorAtRest() response	2018-08-08 09:36:23 +03:00
bunnei	0f834e2284	nvhost_gpu: Don't over copy IoctlSubmitGpfifo.	2018-08-08 01:49:47 -04:00
bunnei	b7fb9f2071	am: Stub SetScreenShotImageOrientation. ... - Used by Super Mario Odyssey.	2018-08-08 00:41:35 -04:00
Lioncash	934a2b9604	acc: Add missing function table entries for GetUserCount ... Given this is stubbed within the common module in 5ac7b84, it should be added to the other relevant tables as well.	2018-08-07 22:50:45 -04:00
bunnei	2bc296801a	acc: Stub GetUserCount. (#973) ... - Used by Pokken Tournament DX.	2018-08-07 22:39:12 -04:00
Lioncash	d378d98e26	nvdrv: Get rid of global std::weak_ptr ... Rather than use global state, we can simply pass the instance into the NVFlinger instance directly.	2018-08-07 21:53:05 -04:00
bunnei	7ed8565978	Merge pull request #957 from lioncash/event ... nvflinger: Correct typo in name of composition event	2018-08-07 15:56:51 -04:00
bunnei	6576bc8927	Merge pull request #954 from lioncash/hid ... services/hid: Add ActivateNpadWithRevision() to the hid function info array	2018-08-07 15:56:34 -04:00
bunnei	2d57cbaec1	Merge pull request #960 from lioncash/apm ... service/apm: Add the apm:sys service	2018-08-07 14:57:12 -04:00
bunnei	573a66c23d	Merge pull request #955 from lioncash/view ... nvflinger: Use std::string_view in OpenDisplay()	2018-08-07 14:26:51 -04:00
bunnei	97c6f984dc	Merge pull request #953 from lioncash/time ... service/time: Amend command IDs of ToPosixTime() and ToPosixTimeWithMyRule()	2018-08-07 14:25:52 -04:00
bunnei	b09c4f45c7	Merge pull request #956 from lioncash/nv ... nvdrv: Get rid of indirect inclusions	2018-08-07 14:23:32 -04:00
Lioncash	12ab5a0547	service/apm: Add the apm:sys service ... Adds the basic skeleton of the apm:sys service based off the information on Switch Brew.	2018-08-07 10:05:26 -04:00
Lioncash	d3f64785d1	nvflinger: Correct typo in name of composition event	2018-08-07 09:03:52 -04:00
Lioncash	300ab211e8	nvdrv: Make Ioctl()'s definition match its prototype ... The only reason this wasn't a compilation error is because we use little-endian systems.	2018-08-07 08:57:11 -04:00
Lioncash	fa8017295b	nvdrv: Get rid of indirect inclusions	2018-08-07 08:54:50 -04:00
Lioncash	e40b0cf437	nvflinger: Get rid of indirect inclusions	2018-08-07 08:32:05 -04:00
Lioncash	7e49881b7f	nvflinger: Use std::string_view in OpenDisplay() ... We don't need to use a std::string here, given all that's done is comparing the character sequence against another. This allows passing regular const char* without needing to heap allocate.	2018-08-07 08:32:06 -04:00
Lioncash	890e543304	services/hid: Add ActivateNpadWithRevision() to the hid function info array ... Updated based off the information on Switch Brew.	2018-08-07 03:23:20 -04:00
Lioncash	20c976ff2a	service/time: Amend command IDs of ToPosixTime() and ToPosixTimeWithMyRule() ... Updates the ID of these based off the information on Switch Brew.	2018-08-07 03:18:07 -04:00
Lioncash	45bc449ff9	service: Add usb services ... Adds basic skeleton for the usb services based off the information provided by Switch Brew.	2018-08-07 03:14:03 -04:00
mailwl	2ea0f0fd16	Service/Audio: audout_a.cpp: remove pragma once	2018-08-06 12:29:27 +03:00
bunnei	bb21c2198a	Merge pull request #925 from bunnei/audren ... Implement audren audio output	2018-08-05 23:35:22 -04:00
bunnei	c0af42d6eb	Merge pull request #912 from lioncash/global-var ... video_core: Eliminate the g_renderer global variable	2018-08-05 16:37:39 -04:00
bunnei	b46df98e93	audio_core: Implement audren_u audio playback.	2018-08-04 21:54:30 -04:00
bunnei	a0a605df06	Merge pull request #924 from lioncash/arp ... service: Add arp services	2018-08-04 21:20:26 -04:00
bunnei	1dee8ceda1	audio_core: Use s16 where possible for audio samples.	2018-08-04 18:22:58 -04:00
bunnei	f1cb3903ac	audio_core: Port codec code from Citra for ADPCM decoding.	2018-08-04 18:22:58 -04:00
Lioncash	de72956181	service: Add arp services ... Adds the basic skeleton of the arp services based off the information provided by Switch Brew.	2018-08-04 18:01:12 -04:00
Lioncash	df51207ed2	service: Remove redundant #pragma once directives ... These don't do anything within .cpp files (we don't include cpp files, so...)	2018-08-04 17:39:08 -04:00
bunnei	9f846d3aa4	audio_core: Streams need unique names for CoreTiming.	2018-08-04 14:34:12 -04:00
Lioncash	2665457f4a	renderer_base: Make Rasterizer() return the rasterizer by reference ... All calling code assumes that the rasterizer will be in a valid state, which is a totally fine assumption. The only way the rasterizer wouldn't be is if initialization is done incorrectly or fails, which is checked against in System::Init().	2018-08-04 02:36:58 -04:00
Lioncash	6030c5ce41	video_core: Eliminate the g_renderer global variable ... We move the initialization of the renderer to the core class, while keeping the creation of it and any other specifics in video_core. This way we can ensure that the renderer is initialized and doesn't give unfettered access to the renderer. This also makes dependencies on types more explicit. For example, the GPU class doesn't need to depend on the existence of a renderer, it only needs to care about whether or not it has a rasterizer, but since it was accessing the global variable, it was also making the renderer a part of its dependency chain. By adjusting the interface, we can get rid of this dependency.	2018-08-04 02:36:57 -04:00
David	c1d54f4aea	Added ability to change username & language code in the settings ui. Added IProfile::Get and SET::GetLanguageCode for libnx tests (#851)	2018-08-03 11:02:55 -04:00
bunnei	40e78b9a89	Merge pull request #898 from lioncash/mig ... service: Add migration services	2018-08-03 11:00:27 -04:00
bunnei	4c3c608d59	Merge pull request #894 from lioncash/object ... kernel: Move object class to its own source files	2018-08-03 00:28:43 -04:00
bunnei	e79e967151	Merge pull request #891 from lioncash/ns ... service/ns: Add missing ns services	2018-08-02 14:57:24 -04:00
Lioncash	7469e26e5e	service: Add migration services ... Adds the basic skeleton for the mig:usr service based off information provided by Switch Brew.	2018-08-02 10:09:45 -04:00
Lioncash	bf45092c61	kernel: Move object class to its own source files ... General moving to keep kernel object types separate from the direct kernel code. Also essentially a preliminary cleanup before eliminating global kernel state in the kernel code.	2018-08-01 23:34:42 -04:00
Lioncash	5233040ab4	service: Add psc services ... Adds the basic skeleton for the psc services based off the information provided by Switch Brew.	2018-08-01 23:31:27 -04:00
bunnei	746d7d4d28	Merge pull request #888 from lioncash/caps ... service: Add capture services	2018-08-01 21:34:28 -04:00
bunnei	9bb8720289	Merge pull request #890 from lioncash/logger ... lm: Amend name of ILogger	2018-08-01 21:33:11 -04:00
bunnei	16b2fd9fc8	Merge pull request #889 from lioncash/fsp ... service/filesystem: Add fsp:ldr and fsp:pr services	2018-08-01 21:32:54 -04:00
Lioncash	48acb764a4	service/ns: Add missing ns services ... Implements the basic skeleton of ns:am2, ns:ec, ns:rid, ns:rt, ns:su, ns:vm, and ns:web based off the information provided by Switch Brew and SwIPC.	2018-08-01 18:02:18 -04:00
Lioncash	f77cfab516	lm: Amend name of ILogger ... Previously this was being registered with the name "Logger". While we're at it, also change the name of the class to match it.	2018-08-01 17:08:44 -04:00
Lioncash	208a457909	service/filesystem: Add fsp:ldr and fsp:pr services ... Adds the basic skeleton for the remaining fsp services based off information provided by Switch Brew.	2018-08-01 17:01:29 -04:00
Lioncash	e39294c267	service: Add capture services ... Adds the basic skeleton for the capture services based off information provided by Switch Brew.	2018-08-01 16:45:51 -04:00
Lioncash	d109279543	service: Add bpc and pcv services ... Adds the basic skeleton for the remaining pcv-related services based off information on Switch Brew.	2018-08-01 16:13:04 -04:00
bunnei	98af269415	Merge pull request #880 from lioncash/audio ... service/audio: Add missing services	2018-07-31 20:11:04 -07:00
Lioncash	bba63b33a1	service/audio: Add missing services ... Adds the missing audctl service, as well as the :a and :d services for audin, audout, audrec, and audren.	2018-07-31 21:58:30 -04:00
bunnei	da07faebfe	Merge pull request #879 from lioncash/audio ... audout_u: Remove std::move in OpenAudioOutImpl()	2018-07-31 16:49:56 -07:00
bunnei	3575c076cb	Merge pull request #869 from Subv/ubsan ... Corrected a few error cases detected by asan/ubsan	2018-07-31 09:24:13 -07:00
bunnei	fd020ad52a	Merge pull request #875 from lioncash/fgm ... service: Add fgm services	2018-07-31 09:23:17 -07:00
bunnei	3a2581cc7d	Merge pull request #874 from lioncash/am ... service/am: Add missing am services	2018-07-31 09:22:56 -07:00
Lioncash	1ced7bbea5	audout_u: Remove std::move in OpenAudioOutImpl() ... Previously the code was using the values from params further below after it was std::moved. Thankfully, given AudoutParams is a trivially copyable struct, the values would have simply been copied in this instance and not invalidated to garbage values.	2018-07-31 10:24:38 -04:00
Lioncash	7da8f15461	service/am: Add missing am services ... Adds the basic skeleton for missing am services idle:sys, omm, and spsm based off the information provided by Switch Brew.	2018-07-31 08:02:20 -04:00
Lioncash	268eeeb406	service: Add fgm services ... Adds the basic skeleton for the fgm services based off the information provided by Switch Brew.	2018-07-31 08:01:19 -04:00
Lioncash	e373027a73	service: Add the pcie service ... Adds the basic skeleton of the pcie service based off information on Switch Brew.	2018-07-31 06:40:21 -04:00
Subv	e119e17d18	nvhost_gpu: Added checks to ensure we don't read past the end of the entries when handling a GPU command list.	2018-07-30 20:09:13 -05:00
Subv	2482aca7c3	nvhost_ctrl_gpu: Only read the input parameters if they are actually there. ... Passing nullptr to memcpy is undefined behavior.	2018-07-30 20:08:36 -05:00
bunnei	eaf66b4c9f	audio_core: Move to audout_u impl. ... - This is necessary so streams are created on the same thread.	2018-07-30 18:44:16 -04:00
David	a483e5e28d	Implemented various hwopus functions (#853)	2018-07-30 15:42:20 -07:00
bunnei	c5fa3560a6	Merge pull request #857 from lioncash/wlan ... service: Add wlan services	2018-07-30 10:06:52 -07:00
bunnei	2c4bb11015	Merge pull request #856 from lioncash/btm ... service: Add btm services	2018-07-30 10:06:34 -07:00
Hexagon12	fd797e2424	Add some HID commands (#843) ... * Added some HID commands * Addressed comments	2018-07-30 10:06:21 -07:00
Lioncash	6ea416091e	service: Add wlan services ... Adds the basic skeleton for the wlan services based off the information on Switch Brew.	2018-07-28 21:54:55 -04:00
Lioncash	7ce6858086	service/btm: Add basic implementation of GetCoreImpl() ... Based off information on SwIPC and Switch Brew.	2018-07-28 21:09:07 -04:00
Lioncash	ca7655be3a	service: Add btm services ... Adds the skeleton for the btm services based off the information on Switch Brew.	2018-07-28 21:09:07 -04:00
bunnei	458fdda700	Merge pull request #847 from lioncash/ncm ... service: Add ncm services	2018-07-28 10:46:09 -07:00
bunnei	d00dcdb1be	Merge pull request #846 from lioncash/mii ... service: Add mii services	2018-07-28 10:45:31 -07:00
bunnei	f1c519f2cb	audout: Implement IAudioOut interface with AudioCore.	2018-07-27 22:55:39 -04:00
Lioncash	7931cc0ceb	service: Add ncm services ... Adds the basic skeleton for the ncm services based off information on Switch Brew.	2018-07-27 17:38:30 -04:00
bunnei	0191a1e526	Merge pull request #845 from lioncash/nfc ... service: Add nfc services	2018-07-27 14:29:27 -07:00
bunnei	833ebbb626	Merge pull request #844 from lioncash/lbl ... service: Add the lbl service	2018-07-27 13:06:11 -07:00
bunnei	d2749ef0ed	Merge pull request #841 from lioncash/btdrv ... service: Add the btdrv service	2018-07-27 13:05:36 -07:00
Lioncash	f46bfdd77d	service: Add mii services ... Adds the skeleton for the mii services based off information provided by Switch Brew	2018-07-27 16:01:29 -04:00
Lioncash	50dadc33e3	service/nfc: Implement Create[x]Interface functions ... These simply return the respective interface.	2018-07-27 15:12:08 -04:00
Lioncash	04d144aa40	service: Add nfc services ... Adds the skeleton of the nfc service based off the information provided on Switch Brew.	2018-07-27 14:50:24 -04:00
Lioncash	ea8dd8b650	service/lbl: Implement EnableVrMode, DisableVrMode and GetVrMode ... Implements these functions according to the information available on Switch Brew.	2018-07-27 14:20:42 -04:00
Lioncash	c2c543e8f7	service: Add the lbl service ... Adds the skeleton of the lbl service based off the information provided by Switch Brew.	2018-07-27 14:20:07 -04:00
Lioncash	f49248437e	service: Add the btdrv service ... Adds the skeleton for the btdrv service based off the information provided by Switch Brew	2018-07-26 18:06:17 -04:00
Lioncash	1121622dc1	service/hid: Add the hidbus, hid:dbg, hid:sys, and hid:tmp services	2018-07-26 15:05:42 -04:00
Lioncash	7550c2c866	service/hid: Add the xcd:sys service	2018-07-26 15:05:42 -04:00
Lioncash	82cb5f030d	service/hid: Add irs services	2018-07-26 15:05:24 -04:00
bunnei	8440b814bc	Merge pull request #834 from lioncash/grc ... service: Add the grc:c service	2018-07-26 12:03:30 -07:00
bunnei	41d7b020a8	Merge pull request #832 from lioncash/nim ... service: Add the nim services	2018-07-26 12:02:29 -07:00
bunnei	e4191b624c	Merge pull request #831 from lioncash/ldn ... service: Add ldn services	2018-07-26 11:52:42 -07:00
bunnei	40eb243f86	Merge pull request #830 from lioncash/socket ... service/sockets: Add missing socket services	2018-07-26 11:51:11 -07:00
Lioncash	b28af1f6c9	service: Add the grc:c service ... Adds the basic skeleton for the grc:c service based off the information provided by Switch Brew.	2018-07-26 09:53:58 -04:00
Lioncash	f916611e32	service: Add the nim services ... Adds the skeleton for the nim services based off information from Switch Brew.	2018-07-26 02:47:06 -04:00
Lioncash	8781beaf0d	service: Add ldn services ... Adds ldn services based off information provided by Switch Brew.	2018-07-26 01:48:06 -04:00
bunnei	57cd80c410	Merge pull request #827 from lioncash/log ... service/lm: Minor changes	2018-07-25 22:30:43 -07:00
Lioncash	3f5dfc4d96	service/sockets: Add ethc:c and ethc:i services	2018-07-26 01:07:21 -04:00
Lioncash	165e7645e1	service/sockets: Add missing bsdcfg socket service	2018-07-26 01:00:15 -04:00
Sebastian Valle	1958d07d7d	Merge pull request #828 from lioncash/ldr ... service: Add ldr services	2018-07-25 23:44:13 -05:00
Sebastian Valle	8ac52c6b56	Merge pull request #826 from lioncash/erpt ... service: Add erpt and eupld services	2018-07-25 23:43:47 -05:00
Sebastian Valle	0e05f98be2	Merge pull request #823 from lioncash/nifm ... service/nifm: Deduplicate interface code	2018-07-25 23:43:03 -05:00
Lioncash	3fb124961e	service: Add ldr services ... Adds the skeleton for the ldr-related services based off the information provided on Switch Brew.	2018-07-25 23:11:03 -04:00
Lioncash	91d86df920	lm: Move LM's class declaration into the cpp file ... This isn't used directly outside of this translation unit, so we can hide it from external use.	2018-07-25 22:40:16 -04:00
Lioncash	6f4d3d8163	lm: Amend names of Initialize() in Logger and Initialize() in LM ... Amends these to match the information on Switch Brew.	2018-07-25 22:39:39 -04:00
Lioncash	8650be1020	lm: Add missing function entry to Logger's function table	2018-07-25 22:26:32 -04:00
Lioncash	7458e71f24	service: Add eupld services ... Adds the skeleton for the eupld services based off information on Switch Brew.	2018-07-25 22:13:43 -04:00
Lioncash	821f2c03cb	service: Add the erpt services ... Adds the basic skeleton of the erpt service based off information on Switch Brew.	2018-07-25 22:13:39 -04:00
bunnei	b0adb9a3d9	Merge pull request #824 from lioncash/nvdrv ... service/nvdrv: Minor changes	2018-07-25 19:02:08 -07:00
bunnei	851089b482	Merge pull request #822 from lioncash/pm ... service: Add pm services	2018-07-25 19:01:28 -07:00
Lioncash	f9951352f6	service/nvdrv: Take std::string in Open() by const reference ... Avoids copies from being made, since the string is only ever used for lookup, the data is never transfered anywhere. Ideally, we'd use a std::string_view here, but devices is a std::unordered_map, not a std::map, so we can't use heterogenous lookup here.	2018-07-25 17:37:43 -04:00
Lioncash	a2cd07d094	service/nvdrv: Use std::move where applicable ... Avoids unnecessary reference count increments and decrements. In one case, we don't need to make a shared_ptr copy at all, just to call a member function.	2018-07-25 17:31:08 -04:00